Browse Source

fix(demo): fix console warning on init (#332)

fixes error on demo initialization by not calling osmd.render before a sample is loaded
the Resize handler executes callback function at initialization, could be changed as well

* demo: fix resize skipping enable
sschmidTU 6 years ago
parent
commit
0845c6d6be
1 changed files with 12 additions and 2 deletions
  1. 12 2
      demo/index.js

+ 12 - 2
demo/index.js

@@ -4,6 +4,7 @@ import { OpenSheetMusicDisplay } from '../src/OpenSheetMusicDisplay/OpenSheetMus
 (function () {
     "use strict";
     var openSheetMusicDisplay;
+    var sampleLoaded = false;
     // folder of the sample files
     var sampleFolder = process.env.STATIC_FILES_SUBFOLDER ? process.env.STATIC_FILES_SUBFOLDER + "/" : "",
     samples = {
@@ -122,9 +123,17 @@ import { OpenSheetMusicDisplay } from '../src/OpenSheetMusicDisplay/OpenSheetMus
         // Set resize event handler
         new Resize(
             function(){
+                if (!sampleLoaded) {
+                    return;
+                }
+
                 disable();
-            },
-            function() {
+                },
+            function(){
+                if (!sampleLoaded) {
+                    return;
+                }
+
                 var width = document.body.clientWidth;
                 canvas.width = width;
                 try {
@@ -229,6 +238,7 @@ import { OpenSheetMusicDisplay } from '../src/OpenSheetMusicDisplay/OpenSheetMus
     }
 
     function onLoadingEnd(isCustom) {
+        sampleLoaded = true;
         // Remove option from select
         if (!isCustom && custom.parentElement === selectSample) {
             selectSample.removeChild(custom);