浏览代码

fix(Ornaments): Mordent and inverted mordent reversed (mordent with line), according to MusicXML definition (#866)

apparently the definitions of mordent and inverted mordent switched in the 19th century
from the original baroque definitions.
Since we interpret MusicXML, we'll use the MusicXML definitions,
where mordent has a line through.
(Vexflow is using the opposite, baroque definition)
sschmid 4 年之前
父节点
当前提交
1237bec904
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      src/MusicalScore/Graphical/VexFlow/VexFlowConverter.ts

+ 2 - 2
src/MusicalScore/Graphical/VexFlow/VexFlowConverter.ts

@@ -494,7 +494,7 @@ export class VexFlowConverter {
                 break;
             }
             case OrnamentEnum.InvertedMordent: {
-                vfOrna = new Vex.Flow.Ornament("mordent_inverted");
+                vfOrna = new Vex.Flow.Ornament("mordent"); // Vexflow uses baroque, not MusicXML definition
                 vfOrna.setDelayed(false);
                 break;
             }
@@ -504,7 +504,7 @@ export class VexFlowConverter {
                 break;
             }
             case OrnamentEnum.Mordent: {
-                vfOrna = new Vex.Flow.Ornament("mordent");
+                vfOrna = new Vex.Flow.Ornament("mordent_inverted");
                 vfOrna.setDelayed(false);
                 break;
             }