Selaa lähdekoodia

fix(OSMDOptions): fix EngravingRules being overwritten by DrawingParameters constructor (in MusicSheetDrawer only)

fixes compact mode OSMDOption being overwritten
refactor(DrawingParameters): simplify setForCompactMode
sschmidTU 6 vuotta sitten
vanhempi
commit
cd49081cfb

+ 4 - 9
src/MusicalScore/Graphical/DrawingParameters.ts

@@ -103,16 +103,11 @@ export class DrawingParameters {
     public setForCompactMode(): void {
         this.setForDefault();
         EngravingRules.Rules.CompactMode = true;
-        this.drawTitle = false;
-        EngravingRules.Rules.RenderTitle = false;
-        this.drawSubtitle = false;
-        EngravingRules.Rules.RenderSubtitle = false;
-        this.drawComposer = false;
-        EngravingRules.Rules.RenderComposer = false;
-        this.drawLyricist = false;
-        EngravingRules.Rules.RenderLyricist = false;
+        this.DrawTitle = false;
+        this.DrawComposer = false;
+        this.DrawLyricist = false;
+        // this.DrawPartNames = true; // unnecessary
         this.drawCredits = false;
-        this.drawPartNames = true;
         this.drawHiddenNotes = false;
     }
 

+ 1 - 1
src/MusicalScore/Graphical/MusicSheetDrawer.ts

@@ -38,7 +38,7 @@ import { GraphicalInstantaneousDynamicExpression } from "./GraphicalInstantaneou
  * This class also includes the resizing and positioning of the symbols due to user interaction like zooming or panning.
  */
 export abstract class MusicSheetDrawer {
-    public drawingParameters: DrawingParameters = new DrawingParameters();
+    public drawingParameters: DrawingParameters;
     public splitScreenLineColor: number;
     public midiPlaybackAvailable: boolean;
     public drawableBoundingBoxElement: string = process.env.DRAW_BOUNDING_BOX_ELEMENT;