浏览代码

fix: improved slur fix - removed magic number. Should work now for tabs as well.

Matthias Uiberacker 5 年之前
父节点
当前提交
f67428ca41
共有 1 个文件被更改,包括 1 次插入11 次删除
  1. 1 11
      src/MusicalScore/Graphical/GraphicalSlur.ts

+ 1 - 11
src/MusicalScore/Graphical/GraphicalSlur.ts

@@ -586,17 +586,7 @@ export class GraphicalSlur extends GraphicalCurve {
 
         // get SkyBottomLine borders
         const minAbove: number = skyBottomLineCalculator.getSkyLineMinInRange(sX, eX) * -1;
-        const maxBelow: number = skyBottomLineCalculator.getBottomLineMaxInRange(sX, eX) - 4;
-
-        // get lowest and highest placed NoteHead
-        // const notesMinY: number = Math.min(startStaffEntry.PositionAndShape.BorderTop,
-        //                                    endStaffEntry.PositionAndShape.BorderTop);
-        // const notesMaxY: number = Math.max(startStaffEntry.PositionAndShape.BorderBottom,
-        //                                    endStaffEntry.PositionAndShape.BorderBottom);
-
-        // get lowest and highest placed NoteHead
-        // minAbove = notesMinY - minAbove;
-        // maxBelow = maxBelow - notesMaxY;
+        const maxBelow: number = skyBottomLineCalculator.getBottomLineMaxInRange(sX, eX) - staffLine.StaffHeight;
 
         if (maxBelow > minAbove) {
             this.placement = PlacementEnum.Above;