فهرست منبع

fix(Pedals): Fix pedal line not always detected, and pedals duplicate/overlapping

sschmidTU 3 سال پیش
والد
کامیت
ff16363b9c
1فایلهای تغییر یافته به همراه4 افزوده شده و 5 حذف شده
  1. 4 5
      src/MusicalScore/ScoreIO/MusicSymbolModules/ExpressionReader.ts

+ 4 - 5
src/MusicalScore/ScoreIO/MusicSymbolModules/ExpressionReader.ts

@@ -342,14 +342,13 @@ export class ExpressionReader {
                         line = true;
                     } else if (pedalNode.attribute("line")?.value === "no"){
                         line = false;
-                        //No on line implies yes on sign
+                        //No line implies sign
                         sign = true;
-                    }
-                    if (pedalNode.attribute("sign")?.value === "yes") {
+                    } else if (pedalNode.attribute("sign")?.value === "yes") {
                         sign = true;
-                    } else if (pedalNode.attribute("sign")?.value === "no"){
+                    } else { //if (pedalNode.attribute("sign")?.value === "no"){
+                        // only assume sign if explicitly given in one way or another
                         sign = false;
-                        //No on sign implies yes on line
                         line = true;
                     }
                     switch (pedalNode.attribute("type").value) {