Selaa lähdekoodia

Remove native gesture "support" from iOS (#2457)

We were processing both the touch move and gesture on iOS which was first firing twice as many set state, but also caused issues:
- The gesture implementation didn't support zooming on the center
- Touching down on a circle and then on the bottom chrome would freak out because initialScale was null

Touching down on the menu still isn't perfect as it shifts the shape around but doesn't completly break the zoom
Christopher Chedeau 4 vuotta sitten
vanhempi
commit
2b6d1470f9
1 muutettua tiedostoa jossa 0 lisäystä ja 16 poistoa
  1. 0 16
      src/components/App.tsx

+ 0 - 16
src/components/App.tsx

@@ -1386,30 +1386,14 @@ class App extends React.Component<ExcalidrawProps, AppState> {
 
   private onGestureStart = withBatchedUpdates((event: GestureEvent) => {
     event.preventDefault();
-    this.setState({
-      selectedElementIds: {},
-    });
-    gesture.initialScale = this.state.zoom.value;
   });
 
   private onGestureChange = withBatchedUpdates((event: GestureEvent) => {
     event.preventDefault();
-    this.setState(({ zoom }) => ({
-      zoom: getNewZoom(
-        getNormalizedZoom(gesture.initialScale! * event.scale),
-        zoom,
-        { x: cursorX, y: cursorY },
-      ),
-    }));
   });
 
   private onGestureEnd = withBatchedUpdates((event: GestureEvent) => {
     event.preventDefault();
-    this.setState({
-      previousSelectedElementIds: {},
-      selectedElementIds: this.state.previousSelectedElementIds,
-    });
-    gesture.initialScale = null;
   });
 
   private handleTextWysiwyg(