Преглед на файлове

Fix scrollbars when no elements (#2460)

I already fixed this but a special case for no elements was added in getCommonBounds to return 0 and reintroduce this bug. I'm not exactly sure where to put this check tbh. Fixing it here so that I'm not annoyed anymore at least.

I checked some of the callsites, some of them related to selection will never pass an empty array, some to export will break if we remove the 0, 0, 0, 0 fix.
Christopher Chedeau преди 4 години
родител
ревизия
5071cffb02
променени са 1 файла, в които са добавени 6 реда и са изтрити 0 реда
  1. 6 0
      src/scene/scrollbars.ts

+ 6 - 0
src/scene/scrollbars.ts

@@ -23,6 +23,12 @@ export const getScrollBars = (
     zoom: Zoom;
   },
 ): ScrollBars => {
+  if (elements.length === 0) {
+    return {
+      horizontal: null,
+      vertical: null,
+    };
+  }
   // This is the bounding box of all the elements
   const [
     elementsMinX,