浏览代码

fix: don't bump element version when adding files data (#4794)

* fix: don't bump element version when adding files data

* fix lint
David Luzar 3 年之前
父节点
当前提交
5c61613a2e
共有 1 个文件被更改,包括 1 次插入9 次删除
  1. 1 9
      src/components/App.tsx

+ 1 - 9
src/components/App.tsx

@@ -115,11 +115,7 @@ import {
   updateBoundElements,
   updateBoundElements,
 } from "../element/binding";
 } from "../element/binding";
 import { LinearElementEditor } from "../element/linearElementEditor";
 import { LinearElementEditor } from "../element/linearElementEditor";
-import {
-  bumpVersion,
-  mutateElement,
-  newElementWith,
-} from "../element/mutateElement";
+import { mutateElement, newElementWith } from "../element/mutateElement";
 import { deepCopyElement, newFreeDrawElement } from "../element/newElement";
 import { deepCopyElement, newFreeDrawElement } from "../element/newElement";
 import {
 import {
   hasBoundTextElement,
   hasBoundTextElement,
@@ -1620,9 +1616,6 @@ class App extends React.Component<AppProps, AppState> {
 
 
       this.files = { ...this.files, ...Object.fromEntries(filesMap) };
       this.files = { ...this.files, ...Object.fromEntries(filesMap) };
 
 
-      // bump versions for elements that reference added files so that
-      // we/host apps can detect the change, and invalidate the image & shape
-      // cache
       this.scene.getElements().forEach((element) => {
       this.scene.getElements().forEach((element) => {
         if (
         if (
           isInitializedImageElement(element) &&
           isInitializedImageElement(element) &&
@@ -1630,7 +1623,6 @@ class App extends React.Component<AppProps, AppState> {
         ) {
         ) {
           this.imageCache.delete(element.fileId);
           this.imageCache.delete(element.fileId);
           invalidateShapeForElement(element);
           invalidateShapeForElement(element);
-          bumpVersion(element);
         }
         }
       });
       });
       this.scene.informMutation();
       this.scene.informMutation();