Browse Source

Disable Sentry inside Docker (#1781)

Kostas Bariotis 4 years ago
parent
commit
8f65e37dac
3 changed files with 8 additions and 7 deletions
  1. 1 3
      Dockerfile
  2. 1 0
      package.json
  3. 6 4
      src/index.tsx

+ 1 - 3
Dockerfile

@@ -17,12 +17,10 @@ COPY . .
 FROM node:14-alpine AS build
 
 ARG NODE_ENV=production
-ARG REACT_APP_INCLUDE_GTAG=false
 
 WORKDIR /opt/node_app
 COPY --from=deps /opt/node_app .
-RUN ls
-RUN npm run build:app
+RUN npm run build:app:docker
 
 FROM nginx:1.17-alpine
 

+ 1 - 0
package.json

@@ -75,6 +75,7 @@
     "build": "npm run build:app && npm run build:zip",
     "build-node": "node ./scripts/build-node.js",
     "build:app": "REACT_APP_INCLUDE_GTAG=true REACT_APP_GIT_SHA=$NOW_GITHUB_COMMIT_SHA react-scripts build",
+    "build:app:docker": "REACT_APP_INCLUDE_GTAG=false REACT_APP_DISABLE_SENTRY=true react-scripts build",
     "build:zip": "node ./scripts/build-version.js",
     "eject": "react-scripts eject",
     "fix": "npm run fix:other && npm run fix:code",

+ 6 - 4
src/index.tsx

@@ -27,12 +27,14 @@ const SentryEnvHostnameMap: { [key: string]: string } = {
   "now.sh": "staging",
 };
 
-const onlineEnv = Object.keys(SentryEnvHostnameMap).find(
-  (item) => window.location.hostname.indexOf(item) >= 0,
-);
+// Disable Sentry locally or inside the Docker to avoid noise/respect privacy
+const onlineEnv =
+  process.env.REACT_APP_DISABLE_SENTRY !== "true" &&
+  Object.keys(SentryEnvHostnameMap).find(
+    (item) => window.location.hostname.indexOf(item) >= 0,
+  );
 
 Sentry.init({
-  // Disable Sentry locally to avoid noise
   dsn: onlineEnv
     ? "https://7bfc596a5bf945eda6b660d3015a5460@sentry.io/5179260"
     : undefined,