Browse Source

Reduce the maximum size of the binding gap (#2450)

Lipis 4 years ago
parent
commit
c7b5cdb71e
2 changed files with 3 additions and 3 deletions
  1. 1 1
      src/element/collision.ts
  2. 2 2
      src/tests/binding.test.tsx

+ 1 - 1
src/element/collision.ts

@@ -133,7 +133,7 @@ export const maxBindingGap = (
   const shapeRatio = element.type === "diamond" ? 1 / Math.sqrt(2) : 1;
   const smallerDimension = shapeRatio * Math.min(elementWidth, elementHeight);
   // We make the bindable boundary bigger for bigger elements
-  return Math.max(15, Math.min(0.25 * smallerDimension, 80));
+  return Math.max(16, Math.min(0.25 * smallerDimension, 32));
 };
 
 type HitTestArgs = {

+ 2 - 2
src/tests/binding.test.tsx

@@ -27,9 +27,9 @@ describe("element binding", () => {
       height: 500,
     });
     const arrow = UI.createElement("arrow", {
-      x: 220,
+      x: 210,
       y: 250,
-      width: 160,
+      width: 180,
       height: 1,
     });
     expect(arrow.startBinding?.elementId).toBe(rectLeft.id);