Kaynağa Gözat

feat: Add validation for website and remove validation for library item name (#4269)

* Github->GitHub

* allow numbers

* remove validation for lib/item name
Aakansha Doshi 3 yıl önce
ebeveyn
işleme
e4d02fb275
2 değiştirilmiş dosya ile 4 ekleme ve 5 silme
  1. 2 3
      src/components/PublishLibrary.tsx
  2. 2 2
      src/locales/en.json

+ 2 - 3
src/components/PublishLibrary.tsx

@@ -120,9 +120,6 @@ const PublishLibrary = ({
       if (!libItem.name) {
         error = t("publishDialog.errors.required");
         isError = true;
-      } else if (!/^[a-zA-Z\s]+$/i.test(libItem.name)) {
-        error = t("publishDialog.errors.letter&Spaces");
-        isError = true;
       }
       erroredLibItems.push({ ...libItem, error });
     });
@@ -381,6 +378,8 @@ const PublishLibrary = ({
               <input
                 type="text"
                 name="website"
+                pattern="https?://.+"
+                title={t("publishDialog.errors.website")}
                 value={libraryData.website}
                 onChange={onInputChange}
                 placeholder={t("publishDialog.placeholder.website")}

+ 2 - 2
src/locales/en.json

@@ -290,13 +290,13 @@
       "authorName": "Your name or username",
       "libraryName": "Name of your library",
       "libraryDesc": "Description of your library to help people understand its usage",
-      "githubHandle": "Github handle (optional), so you can edit the library once submitted for review",
+      "githubHandle": "GitHub handle (optional), so you can edit the library once submitted for review",
       "twitterHandle": "Twitter username (optional), so we know who to credit when promoting over Twitter",
       "website": "Link to your personal website or elsewhere (optional)"
     },
     "errors": {
       "required": "Required",
-      "letter&Spaces": "Only letters and spaces allowed"
+      "website": "Enter a valid Url"
     },
     "noteDescription": {
       "pre": "Submit your library to be included in the ",