Browse Source

fix: remote pointers not accounting for offset (#2855)

David Luzar 4 years ago
parent
commit
e75f5f20e7
2 changed files with 9 additions and 1 deletions
  1. 4 0
      src/packages/excalidraw/CHANGELOG.md
  2. 5 1
      src/renderer/renderScene.ts

+ 4 - 0
src/packages/excalidraw/CHANGELOG.md

@@ -24,6 +24,10 @@ Please add the latest change on the top under the correct section.
 
 - Support `Ctrl-Y` shortcut to redo on Windows [#2831](https://github.com/excalidraw/excalidraw/pull/2831).
 
+### Fixes
+
+- Fix remote pointers not accounting for offset [#2855](https://github.com/excalidraw/excalidraw/pull/2855).
+
 ## 0.2.1
 
 ## Excalidraw API

+ 5 - 1
src/renderer/renderScene.ts

@@ -418,7 +418,9 @@ export const renderScene = (
   // Paint remote pointers
   for (const clientId in sceneState.remotePointerViewportCoords) {
     let { x, y } = sceneState.remotePointerViewportCoords[clientId];
-    const username = sceneState.remotePointerUsernames[clientId];
+
+    x -= appState.offsetLeft;
+    y -= appState.offsetTop;
 
     const width = 9;
     const height = 14;
@@ -473,6 +475,8 @@ export const renderScene = (
     context.fill();
     context.stroke();
 
+    const username = sceneState.remotePointerUsernames[clientId];
+
     if (!isOutOfBounds && username) {
       const offsetX = x + width;
       const offsetY = y + height;