1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054 |
- import ReactDOM from "react-dom";
- import { render } from "./test-utils";
- import ExcalidrawApp from "../excalidraw-app";
- import { reseed } from "../random";
- import {
- actionSendBackward,
- actionBringForward,
- actionBringToFront,
- actionSendToBack,
- actionDuplicateSelection,
- } from "../actions";
- import { AppState } from "../types";
- import { API } from "./helpers/api";
- // Unmount ReactDOM from root
- ReactDOM.unmountComponentAtNode(document.getElementById("root")!);
- beforeEach(() => {
- localStorage.clear();
- reseed(7);
- });
- const { h } = window;
- const populateElements = (
- elements: {
- id: string;
- isDeleted?: boolean;
- isSelected?: boolean;
- groupIds?: string[];
- y?: number;
- x?: number;
- width?: number;
- height?: number;
- }[],
- ) => {
- const selectedElementIds: any = {};
- h.elements = elements.map(
- ({
- id,
- isDeleted = false,
- isSelected = false,
- groupIds = [],
- y = 100,
- x = 100,
- width = 100,
- height = 100,
- }) => {
- const element = API.createElement({
- type: "rectangle",
- id,
- isDeleted,
- x,
- y,
- width,
- height,
- groupIds,
- });
- if (isSelected) {
- selectedElementIds[element.id] = true;
- }
- return element;
- },
- );
- h.setState({
- selectedElementIds,
- });
- return selectedElementIds;
- };
- type Actions =
- | typeof actionBringForward
- | typeof actionSendBackward
- | typeof actionBringToFront
- | typeof actionSendToBack;
- const assertZindex = ({
- elements,
- appState,
- operations,
- }: {
- elements: {
- id: string;
- isDeleted?: true;
- isSelected?: true;
- groupIds?: string[];
- }[];
- appState?: Partial<AppState>;
- operations: [Actions, string[]][];
- }) => {
- const selectedElementIds = populateElements(elements);
- h.setState({
- editingGroupId: appState?.editingGroupId || null,
- });
- operations.forEach(([action, expected]) => {
- h.app.actionManager.executeAction(action);
- expect(h.elements.map((element) => element.id)).toEqual(expected);
- expect(h.state.selectedElementIds).toEqual(selectedElementIds);
- });
- };
- describe("z-index manipulation", () => {
- beforeEach(async () => {
- await render(<ExcalidrawApp />);
- });
- it("send back", () => {
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isDeleted: true },
- { id: "C", isDeleted: true },
- { id: "D", isSelected: true },
- ],
- operations: [
- [actionSendBackward, ["D", "A", "B", "C"]],
- // noop
- [actionSendBackward, ["D", "A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- // noop
- [actionSendBackward, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isDeleted: true },
- { id: "B" },
- { id: "C", isDeleted: true },
- { id: "D", isSelected: true },
- ],
- operations: [[actionSendBackward, ["A", "D", "B", "C"]]],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isDeleted: true },
- { id: "C", isDeleted: true },
- { id: "D", isSelected: true },
- { id: "E", isSelected: true },
- { id: "F" },
- ],
- operations: [
- [actionSendBackward, ["D", "E", "A", "B", "C", "F"]],
- // noop
- [actionSendBackward, ["D", "E", "A", "B", "C", "F"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B" },
- { id: "C", isDeleted: true },
- { id: "D", isDeleted: true },
- { id: "E", isSelected: true },
- { id: "F" },
- { id: "G", isSelected: true },
- ],
- operations: [
- [actionSendBackward, ["A", "E", "B", "C", "D", "G", "F"]],
- [actionSendBackward, ["E", "A", "G", "B", "C", "D", "F"]],
- [actionSendBackward, ["E", "G", "A", "B", "C", "D", "F"]],
- // noop
- [actionSendBackward, ["E", "G", "A", "B", "C", "D", "F"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B" },
- { id: "C", isDeleted: true },
- { id: "D", isSelected: true },
- { id: "E", isDeleted: true },
- { id: "F", isSelected: true },
- { id: "G" },
- ],
- operations: [
- [actionSendBackward, ["A", "D", "E", "F", "B", "C", "G"]],
- [actionSendBackward, ["D", "E", "F", "A", "B", "C", "G"]],
- // noop
- [actionSendBackward, ["D", "E", "F", "A", "B", "C", "G"]],
- ],
- });
- // grouped elements should be atomic
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g1"] },
- { id: "D", isDeleted: true },
- { id: "E", isDeleted: true },
- { id: "F", isSelected: true },
- ],
- operations: [
- [actionSendBackward, ["A", "F", "B", "C", "D", "E"]],
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- // noop
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g2", "g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g1"] },
- { id: "E", isDeleted: true },
- { id: "F", isSelected: true },
- ],
- operations: [
- [actionSendBackward, ["A", "F", "B", "C", "D", "E"]],
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- // noop
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g2", "g1"] },
- { id: "E", isDeleted: true },
- { id: "F", isSelected: true },
- ],
- operations: [
- [actionSendBackward, ["A", "F", "B", "C", "D", "E"]],
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- // noop
- [actionSendBackward, ["F", "A", "B", "C", "D", "E"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B1", groupIds: ["g1"] },
- { id: "C1", groupIds: ["g1"] },
- { id: "D2", groupIds: ["g2"], isSelected: true },
- { id: "E2", groupIds: ["g2"], isSelected: true },
- ],
- appState: {
- editingGroupId: null,
- },
- operations: [[actionSendBackward, ["A", "D2", "E2", "B1", "C1"]]],
- });
- // in-group siblings
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g2", "g1"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendBackward, ["A", "B", "D", "C"]],
- // noop (prevented)
- [actionSendBackward, ["A", "B", "D", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g2", "g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g1"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionSendBackward, ["A", "D", "B", "C"]],
- // noop (prevented)
- [actionSendBackward, ["A", "D", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2", "g1"], isSelected: true },
- { id: "D", groupIds: ["g2", "g1"], isDeleted: true },
- { id: "E", groupIds: ["g2", "g1"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionSendBackward, ["A", "C", "D", "E", "B"]],
- // noop (prevented)
- [actionSendBackward, ["A", "C", "D", "E", "B"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g2", "g1"] },
- { id: "E", groupIds: ["g3", "g1"], isSelected: true },
- { id: "F", groupIds: ["g3", "g1"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionSendBackward, ["A", "B", "E", "F", "C", "D"]],
- [actionSendBackward, ["A", "E", "F", "B", "C", "D"]],
- // noop (prevented)
- [actionSendBackward, ["A", "E", "F", "B", "C", "D"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g1"] },
- { id: "B", groupIds: ["g2"] },
- { id: "C", groupIds: ["g1"] },
- { id: "D", groupIds: ["g2"], isSelected: true },
- { id: "E", groupIds: ["g2"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendBackward, ["A", "D", "E", "B", "C"]],
- // noop
- [actionSendBackward, ["A", "D", "E", "B", "C"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g1"] },
- { id: "B", groupIds: ["g2"] },
- { id: "C", groupIds: ["g1"] },
- { id: "D", groupIds: ["g2"], isSelected: true },
- { id: "F" },
- { id: "G", groupIds: ["g2"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendBackward, ["A", "D", "G", "B", "C", "F"]],
- // noop
- [actionSendBackward, ["A", "D", "G", "B", "C", "F"]],
- ],
- });
- });
- it("bring forward", () => {
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- { id: "D", isDeleted: true },
- { id: "E" },
- ],
- operations: [
- [actionBringForward, ["A", "D", "E", "B", "C"]],
- // noop
- [actionBringForward, ["A", "D", "E", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- // noop
- [actionBringForward, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isDeleted: true },
- { id: "C", isDeleted: true },
- { id: "D" },
- { id: "E", isSelected: true },
- { id: "F", isDeleted: true },
- { id: "G" },
- ],
- operations: [
- [actionBringForward, ["B", "C", "D", "A", "F", "G", "E"]],
- [actionBringForward, ["B", "C", "D", "F", "G", "A", "E"]],
- // noop
- [actionBringForward, ["B", "C", "D", "F", "G", "A", "E"]],
- ],
- });
- // grouped elements should be atomic
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isDeleted: true },
- { id: "C", isDeleted: true },
- { id: "D", groupIds: ["g1"] },
- { id: "E", groupIds: ["g1"] },
- { id: "F" },
- ],
- operations: [
- [actionBringForward, ["B", "C", "D", "E", "A", "F"]],
- [actionBringForward, ["B", "C", "D", "E", "F", "A"]],
- // noop
- [actionBringForward, ["B", "C", "D", "E", "F", "A"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isSelected: true },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g2", "g1"] },
- { id: "E", groupIds: ["g1"] },
- { id: "F" },
- ],
- operations: [
- [actionBringForward, ["A", "C", "D", "E", "B", "F"]],
- [actionBringForward, ["A", "C", "D", "E", "F", "B"]],
- // noop
- [actionBringForward, ["A", "C", "D", "E", "F", "B"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isSelected: true },
- { id: "C", groupIds: ["g1"] },
- { id: "D", groupIds: ["g2", "g1"] },
- { id: "E", groupIds: ["g2", "g1"] },
- { id: "F" },
- ],
- operations: [
- [actionBringForward, ["A", "C", "D", "E", "B", "F"]],
- [actionBringForward, ["A", "C", "D", "E", "F", "B"]],
- // noop
- [actionBringForward, ["A", "C", "D", "E", "F", "B"]],
- ],
- });
- // in-group siblings
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g2", "g1"], isSelected: true },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringForward, ["A", "C", "B", "D"]],
- // noop (prevented)
- [actionBringForward, ["A", "C", "B", "D"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g1"], isSelected: true },
- { id: "B", groupIds: ["g2", "g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D" },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionBringForward, ["B", "C", "A", "D"]],
- // noop (prevented)
- [actionBringForward, ["B", "C", "A", "D"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g2", "g1"], isSelected: true },
- { id: "B", groupIds: ["g2", "g1"], isSelected: true },
- { id: "C", groupIds: ["g1"] },
- { id: "D" },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionBringForward, ["C", "A", "B", "D"]],
- // noop (prevented)
- [actionBringForward, ["C", "A", "B", "D"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g2"], isSelected: true },
- { id: "B", groupIds: ["g2"], isSelected: true },
- { id: "C", groupIds: ["g1"] },
- { id: "D", groupIds: ["g2"] },
- { id: "E", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringForward, ["C", "D", "A", "B", "E"]],
- // noop
- [actionBringForward, ["C", "D", "A", "B", "E"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g2"], isSelected: true },
- { id: "B" },
- { id: "C", groupIds: ["g2"], isSelected: true },
- { id: "D", groupIds: ["g1"] },
- { id: "E", groupIds: ["g2"] },
- { id: "F", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringForward, ["B", "D", "E", "A", "C", "F"]],
- // noop
- [actionBringForward, ["B", "D", "E", "A", "C", "F"]],
- ],
- });
- });
- it("bring to front", () => {
- assertZindex({
- elements: [
- { id: "0" },
- { id: "A", isSelected: true },
- { id: "B", isDeleted: true },
- { id: "C", isDeleted: true },
- { id: "D" },
- { id: "E", isSelected: true },
- { id: "F", isDeleted: true },
- { id: "G" },
- ],
- operations: [
- [actionBringToFront, ["0", "B", "C", "D", "F", "G", "A", "E"]],
- // noop
- [actionBringToFront, ["0", "B", "C", "D", "F", "G", "A", "E"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- // noop
- [actionBringToFront, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- // noop
- [actionBringToFront, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C" },
- ],
- operations: [
- [actionBringToFront, ["C", "A", "B"]],
- // noop
- [actionBringToFront, ["C", "A", "B"]],
- ],
- });
- // in-group sorting
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g1"], isSelected: true },
- { id: "D", groupIds: ["g1"] },
- { id: "E", groupIds: ["g1"], isSelected: true },
- { id: "F", groupIds: ["g2", "g1"] },
- { id: "G", groupIds: ["g2", "g1"] },
- { id: "H", groupIds: ["g3", "g1"] },
- { id: "I", groupIds: ["g3", "g1"] },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionBringToFront, ["A", "B", "D", "F", "G", "H", "I", "C", "E"]],
- // noop (prevented)
- [actionBringToFront, ["A", "B", "D", "F", "G", "H", "I", "C", "E"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g2", "g1"], isSelected: true },
- { id: "D", groupIds: ["g2", "g1"] },
- { id: "C", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringToFront, ["A", "D", "B", "C"]],
- // noop (prevented)
- [actionBringToFront, ["A", "D", "B", "C"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g2", "g3"], isSelected: true },
- { id: "B", groupIds: ["g1", "g3"] },
- { id: "C", groupIds: ["g2", "g3"] },
- { id: "D", groupIds: ["g1", "g3"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringToFront, ["B", "C", "A", "D"]],
- // noop
- [actionBringToFront, ["B", "C", "A", "D"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g2"], isSelected: true },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2"] },
- { id: "D", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionBringToFront, ["B", "C", "A", "D"]],
- // noop
- [actionBringToFront, ["B", "C", "A", "D"]],
- ],
- });
- });
- it("send to back", () => {
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isDeleted: true },
- { id: "C" },
- { id: "D", isDeleted: true },
- { id: "E", isSelected: true },
- { id: "F", isDeleted: true },
- { id: "G" },
- { id: "H", isSelected: true },
- { id: "I" },
- ],
- operations: [
- [actionSendToBack, ["E", "H", "A", "B", "C", "D", "F", "G", "I"]],
- // noop
- [actionSendToBack, ["E", "H", "A", "B", "C", "D", "F", "G", "I"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- // noop
- [actionSendToBack, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- { id: "C" },
- ],
- operations: [
- // noop
- [actionSendToBack, ["A", "B", "C"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", isSelected: true },
- { id: "C", isSelected: true },
- ],
- operations: [
- [actionSendToBack, ["B", "C", "A"]],
- // noop
- [actionSendToBack, ["B", "C", "A"]],
- ],
- });
- // in-group sorting
- // -------------------------------------------------------------------------
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g2", "g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g3", "g1"] },
- { id: "E", groupIds: ["g3", "g1"] },
- { id: "F", groupIds: ["g1"], isSelected: true },
- { id: "G", groupIds: ["g1"] },
- { id: "H", groupIds: ["g1"], isSelected: true },
- { id: "I", groupIds: ["g1"] },
- ],
- appState: {
- editingGroupId: "g1",
- },
- operations: [
- [actionSendToBack, ["A", "F", "H", "B", "C", "D", "E", "G", "I"]],
- // noop (prevented)
- [actionSendToBack, ["A", "F", "H", "B", "C", "D", "E", "G", "I"]],
- ],
- });
- assertZindex({
- elements: [
- { id: "A" },
- { id: "B", groupIds: ["g1"] },
- { id: "C", groupIds: ["g2", "g1"] },
- { id: "D", groupIds: ["g2", "g1"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendToBack, ["A", "B", "D", "C"]],
- // noop (prevented)
- [actionSendToBack, ["A", "B", "D", "C"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g1", "g3"] },
- { id: "B", groupIds: ["g2", "g3"] },
- { id: "C", groupIds: ["g1", "g3"] },
- { id: "D", groupIds: ["g2", "g3"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendToBack, ["A", "D", "B", "C"]],
- // noop
- [actionSendToBack, ["A", "D", "B", "C"]],
- ],
- });
- // invalid z-indexes across groups (legacy) → allow to sort to next sibling
- assertZindex({
- elements: [
- { id: "A", groupIds: ["g1"] },
- { id: "B", groupIds: ["g2"] },
- { id: "C", groupIds: ["g1"] },
- { id: "D", groupIds: ["g2"], isSelected: true },
- ],
- appState: {
- editingGroupId: "g2",
- },
- operations: [
- [actionSendToBack, ["A", "D", "B", "C"]],
- // noop
- [actionSendToBack, ["A", "D", "B", "C"]],
- ],
- });
- });
- it("duplicating elements should retain zindex integrity", () => {
- populateElements([
- { id: "A", isSelected: true },
- { id: "B", isSelected: true },
- ]);
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements).toMatchObject([
- { id: "A" },
- { id: "A_copy" },
- { id: "B" },
- { id: "B_copy" },
- ]);
- populateElements([
- { id: "A", groupIds: ["g1"], isSelected: true },
- { id: "B", groupIds: ["g1"], isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g1: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements).toMatchObject([
- { id: "A" },
- { id: "B" },
- {
- id: "A_copy",
- groupIds: [expect.stringMatching(/.{3,}/)],
- },
- {
- id: "B_copy",
- groupIds: [expect.stringMatching(/.{3,}/)],
- },
- ]);
- populateElements([
- { id: "A", groupIds: ["g1"], isSelected: true },
- { id: "B", groupIds: ["g1"], isSelected: true },
- { id: "C" },
- ]);
- h.setState({
- selectedGroupIds: { g1: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements).toMatchObject([
- { id: "A" },
- { id: "B" },
- {
- id: "A_copy",
- groupIds: [expect.stringMatching(/.{3,}/)],
- },
- {
- id: "B_copy",
- groupIds: [expect.stringMatching(/.{3,}/)],
- },
- { id: "C" },
- ]);
- populateElements([
- { id: "A", groupIds: ["g1"], isSelected: true },
- { id: "B", groupIds: ["g1"], isSelected: true },
- { id: "C", isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g1: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "A_copy",
- "B_copy",
- "C",
- "C_copy",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1"], isSelected: true },
- { id: "B", groupIds: ["g1"], isSelected: true },
- { id: "C", groupIds: ["g2"], isSelected: true },
- { id: "D", groupIds: ["g2"], isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g1: true, g2: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "A_copy",
- "B_copy",
- "C",
- "D",
- "C_copy",
- "D_copy",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"], isSelected: true },
- { id: "B", groupIds: ["g1", "g2"], isSelected: true },
- { id: "C", groupIds: ["g2"], isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g1: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "A_copy",
- "B_copy",
- "C",
- "C_copy",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"], isSelected: true },
- { id: "B", groupIds: ["g1", "g2"], isSelected: true },
- { id: "C", groupIds: ["g2"], isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g2: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "C",
- "A_copy",
- "B_copy",
- "C_copy",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"], isSelected: true },
- { id: "B", groupIds: ["g1", "g2"], isSelected: true },
- { id: "C", groupIds: ["g2"], isSelected: true },
- { id: "D", groupIds: ["g3", "g4"], isSelected: true },
- { id: "E", groupIds: ["g3", "g4"], isSelected: true },
- { id: "F", groupIds: ["g4"], isSelected: true },
- ]);
- h.setState({
- selectedGroupIds: { g2: true, g4: true },
- });
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "C",
- "A_copy",
- "B_copy",
- "C_copy",
- "D",
- "E",
- "F",
- "D_copy",
- "E_copy",
- "F_copy",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"], isSelected: true },
- { id: "B", groupIds: ["g1", "g2"] },
- { id: "C", groupIds: ["g2"] },
- ]);
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "A_copy",
- "B",
- "C",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"] },
- { id: "B", groupIds: ["g1", "g2"], isSelected: true },
- { id: "C", groupIds: ["g2"] },
- ]);
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "B",
- "B_copy",
- "C",
- ]);
- populateElements([
- { id: "A", groupIds: ["g1", "g2"], isSelected: true },
- { id: "B", groupIds: ["g1", "g2"], isSelected: true },
- { id: "C", groupIds: ["g2"], isSelected: true },
- ]);
- h.app.actionManager.executeAction(actionDuplicateSelection);
- expect(h.elements.map((element) => element.id)).toEqual([
- "A",
- "A_copy",
- "B",
- "B_copy",
- "C",
- "C_copy",
- ]);
- });
- });
|